Remove redundant call to setAnswerQuestion #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's already a call to this in newQuestion, so this is unnecessary.
|
Hm, test failures. Going to mark as a draft until I can investigate further. |
|
I wonder if these tests might not be fixed by #261. |
|
We can check once it's merged. |
|
Just tested against |
|
Alright, I merged main back in and if CI passes I'll hit the button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a call to this in newQuestion, so this is unnecessary.
@lthibault, I seem to recall you having submitted a PR that removed this line, and that change got backed out. Staring at it with nothing else going on, it's clear that this change makes sense, I guess I didn't process it at the time since the change seemed unrelated.